feat(server): Add server config for headers and keep alive timeouts #9309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
marianore-muttdata
force-pushed
the
feat/cube/add-node-keep-alive-headers-timeout-configs
branch
from
2c3f332 to
51681fd
Compare
|
Hi @KSDaemon! Do you think this feature could be added anytime soon? Do you see any utility? |
|
Hey @marianore-muttdata looks good. Could you please rebase it on top of the latest master branch? GitHub shows that there are some conflicts. Thnx! |
KSDaemon
requested changes
Jun 13, 2025
marianore-muttdata
force-pushed
the
feat/cube/add-node-keep-alive-headers-timeout-configs
branch
from
f884557 to
267ce43
Compare
|
Hey @marianore-muttdata! Actually... The tests are failing because of: We forgot to update the options scheme here |
Got it! Let me know if there's anything else that you'd write differently. |
|
I think now everything is fine! :) Let's merge! |
marianore-muttdata
deleted the
feat/cube/add-node-keep-alive-headers-timeout-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This is a change that we've been using in our application to sync the timeouts with the LoadBalancer correctly.
Added two new environment variables to configure HTTP server options:
CUBEJS_SERVER_HEADERS_TIMEOUTCUBEJS_SERVER_KEEP_ALIVE_TIMEOUTEach default to the default values in the
Serverclass found in theHTTPNode module.